Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Reset nonce if out of funds #807

Merged
merged 2 commits into from
Dec 10, 2024
Merged

fix: Reset nonce if out of funds #807

merged 2 commits into from
Dec 10, 2024

Conversation

arcoraven
Copy link
Contributor

@arcoraven arcoraven commented Dec 10, 2024

PR-Codex overview

This PR focuses on improving error handling in the transaction processing workflow by refining how errors related to nonces and insufficient funds are managed, enhancing the clarity and efficiency of the code.

Detailed summary

  • Updated isNonceAlreadyUsedError to simplify error message checks.
  • Changed isInsufficientFundsError to return a more general insufficient funds message.
  • Enhanced error handling in cancel-recycled-nonces-worker.ts to handle insufficient funds before nonce checks.
  • Consolidated imports in cancel-recycled-nonces-worker.ts.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@arcoraven arcoraven merged commit 71fb8b0 into main Dec 10, 2024
5 of 6 checks passed
@arcoraven arcoraven deleted the ph/resetNonceIfOutOfFunds branch December 10, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant