Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(experimental): configure mine worker timeout #797

Merged
merged 2 commits into from
Dec 8, 2024

Conversation

arcoraven
Copy link
Contributor

@arcoraven arcoraven commented Dec 8, 2024

PR-Codex overview

This PR focuses on improving the transaction mining process by refining logging, adjusting retry attempts for transactions, and introducing an experimental environment variable to control the timeout for mining workers.

Detailed summary

  • Updated logging in mineTransactionWorker.ts to display elapsed time instead of transaction hashes.
  • Introduced NUM_ATTEMPTS in mineTransactionQueue.ts to dynamically set retry attempts based on EXPERIMENTAL__MINE_WORKER_TIMEOUT_SECONDS.
  • Added documentation for EXPERIMENTAL__MINE_WORKER_TIMEOUT_SECONDS in env.ts to clarify its purpose.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

job.log(
`Transaction is not mined yet. Check again later. sentTransactionHashes=${sentTransaction.sentTransactionHashes}`,
`Transaction is not mined yet. Check again later. elapsed=${ellapsedMs / 1000}s`,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reduces log lines to minimize memory usage

@arcoraven arcoraven merged commit 1719e0a into main Dec 8, 2024
5 checks passed
@arcoraven arcoraven deleted the ph/mineWorkerTimeoutSeconds branch December 8, 2024 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants