fix: Reset nonce if wallet is out of funds #791
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arcoraven
commented
Dec 6, 2024
src/utils/error.ts
Outdated
| @@ -16,11 +16,9 @@ const _parseMessage = (error: unknown): string | null => { | |||
|
|
|||
| export const isNonceAlreadyUsedError = (error: unknown) => { | |||
| const message = _parseMessage(error); | |||
| const errorPhrases = ["nonce too low", "already known"]; | |||
There was a problem hiding this comment.
cleanup, no logical change
Comment on lines
+360
to
+362
| if (value === 0n) { | ||
| await deleteNoncesForBackendWallets([{ chainId, walletAddress: from }]); | ||
| } |
There was a problem hiding this comment.
This is the main change. If a transaction received an "insufficient funds" error from RPC and no value was provided, this wallet must be low on gas. Reset the nonce so the onchain nonce doesn't remain out of sync.
| return { | ||
| ...queuedTransaction, | ||
| status: "errored", | ||
| errorMessage, | ||
| } satisfies ErroredTransaction; | ||
| } | ||
|
|
||
| if (isNonceAlreadyUsedError(error) || isReplacementGasFeeTooLow(error)) { |
There was a problem hiding this comment.
Just moving this below the "out of funds" block above. No logic changes.
joaquim-verges
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR-Codex overview
This PR focuses on simplifying error handling related to nonce usage and insufficient funds in the transaction process. It refines error checks and modifies the logic for handling insufficient funds, ensuring clearer responses and better nonce management.
Detailed summary
isNonceAlreadyUsedErrorto use direct string checks instead of an array.isInsufficientFundsErrorto check for a single phrase._sendTransactionto improve handling of insufficient funds and nonce recycling.deleteNoncesForBackendWalletscall to reset nonce state when funds are insufficient.