feat: add support for gasPrice in transaction overrides and schemas #784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d4mr
commented
Nov 29, 2024
| @@ -10,8 +10,11 @@ export const txOverridesSchema = Type.Object({ | |||
| description: "Gas limit for the transaction", | |||
| }), | |||
|
|
|||
| // Overriding `gasPrice` is currently not supported. | |||
|
|
|||
| gasPrice: Type.Optional({ | |||
There was a problem hiding this comment.
we could also allow for a boolean true value here, which if detected, engine calculates the right gas amount to send
arcoraven
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR-Codex overview
This PR introduces support for
gasPricein various transaction-related files, enhancing transaction configuration options for both legacy and EIP-1559 types. It updates schemas and utility functions to accommodate this new field.Detailed summary
gasPriceto theoverridestype insrc/utils/transaction/types.ts.src/server/schemas/transaction/index.tsto usetransaction.overrides?.gasPrice.src/server/utils/transactionOverrides.tsto includegasPricein the overrides object.gasPricein the transaction parameters insrc/worker/tasks/sendTransactionWorker.ts.src/server/schemas/txOverrides.tsto supportgasPricewith a description explaining its usage.