Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moved the ARG & ENV to prod stage #313

Merged
merged 1 commit into from
Nov 21, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -60,10 +60,6 @@ CMD [ "sh", "-c", "yarn prisma:setup:dev && yarn dev:worker" ]
# Production Node Modules stage
FROM node:18.15.0-alpine AS prod-dependencies

# Setting ENV variables for image information
ARG ENGINE_VERSION
ENV ENGINE_VERSION=${ENGINE_VERSION}

# Install build dependencies
RUN apk add --no-cache g++ make py3-pip openssl

Expand Down Expand Up @@ -104,6 +100,10 @@ RUN apk del g++ make py3-pip openssl
# Production stage
FROM node:18.15.0-alpine AS prod

# Setting ENV variables for image information
ARG ENGINE_VERSION
ENV ENGINE_VERSION=${ENGINE_VERSION}

# Install tini
RUN apk add --no-cache tini

Expand Down