Split-up core into Router and RouterPayable #10
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Router
andRouterPayable
We split-up the current
core/Router
into two separate optionsRouter
andRouterPayable
. All presets in the/preset
directory useRouter
.Router
does not have a payable fallback function, or areceive
function. This allows for areceive
function to be added as an extension, in contracts built on top ofRouter
or one of the base router presets.RouterPayable
has a payable fallback function and a hardcodedreceive
function.BaseRouter
andBaseRouterWithDefaults
We split-up the current
presets/BaseRouter
into two separate optionsBaseRouter
andBaseRouterWithDefaults
.BaseRouter
no longer usesDefaultExtensionSet
and is not meant to be initialized with default extensions in its constructor.BaseRouterWithDefaults
on the other hand inheritsDefaultExtensionSet
and can be initialized with default extensions in its constructor.