Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split-up core into Router and RouterPayable #10

Merged
merged 5 commits into from
Aug 15, 2023

Conversation

nkrishang
Copy link
Contributor

@nkrishang nkrishang commented Aug 15, 2023

Summary

Router and RouterPayable

We split-up the current core/Router into two separate options Router and RouterPayable. All presets in the /preset directory use Router.

Router does not have a payable fallback function, or a receive function. This allows for a receive function to be added as an extension, in contracts built on top of Router or one of the base router presets.

RouterPayable has a payable fallback function and a hardcoded receive function.

BaseRouter and BaseRouterWithDefaults

We split-up the current presets/BaseRouter into two separate options BaseRouter and BaseRouterWithDefaults.

BaseRouter no longer uses DefaultExtensionSet and is not meant to be initialized with default extensions in its constructor.

BaseRouterWithDefaults on the other hand inherits DefaultExtensionSet and can be initialized with default extensions in its constructor.

@nkrishang nkrishang merged commit f01a887 into main Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant