Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unity Compatibility + Customizability + Various Improvements #25

Merged
merged 16 commits into from
Jun 12, 2024

Conversation

0xFirekeeper
Copy link
Member

@0xFirekeeper 0xFirekeeper commented Jun 4, 2024

Refactor to a cross-platform http client wrapper, must test thoroughly with Unity use case. May require additional conditional compilation.


PR-Codex overview

The focus of this PR is to update encryption iteration count, enhance HTTP client functionality, and improve contract handling.

Detailed summary

  • Updated encryption iteration count for enhanced security
  • Added new HTTP client functionality for better request handling
  • Improved contract handling by passing the client object instead of address and chain ID

The following files were skipped due to too many changes: Thirdweb/Thirdweb.Http/ThirdwebHttpContent.cs, Thirdweb/Thirdweb.Wallets/InAppWallet/EmbeddedWallet/EmbeddedWallet.cs, Thirdweb.Tests/Thirdweb.ZkSmartWallet.Tests.cs, Thirdweb/Thirdweb.Client/ThirdwebClient.cs, Thirdweb/Thirdweb.Storage/ThirdwebStorage.cs, Thirdweb/Thirdweb.Wallets/SmartWallet/Thirdweb.AccountAbstraction/BundlerClient.cs, Thirdweb/Thirdweb.RPC/ThirdwebRPC.cs, Thirdweb/Thirdweb.Http/ThirdwebHttpClient.cs, Thirdweb/Thirdweb.Wallets/PrivateKeyWallet/PrivateKeyWallet.cs, Thirdweb.Tests/Thirdweb.PrivateKeyWallet.Tests.cs, Thirdweb/Thirdweb.Wallets/SmartWallet/SmartWallet.cs, Thirdweb.Tests/Thirdweb.Transactions.Tests.cs, Thirdweb/Thirdweb.Transactions/ThirdwebTransaction.cs, Thirdweb.Tests/Thirdweb.Http.Tests.cs, Thirdweb/Thirdweb.Wallets/InAppWallet/EmbeddedWallet.Authentication/Server.cs

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Refactor to a cross-platform http client wrapper, must test thoroughly with Unity use case.
May require additional conditional compilation.
@codecov-commenter
Copy link

codecov-commenter commented Jun 4, 2024

Codecov Report

Attention: Patch coverage is 88.94009% with 24 lines in your changes missing coverage. Please review.

Project coverage is 92.53%. Comparing base (c94e5cc) to head (b872266).
Report is 4 commits behind head on main.

Files Patch % Lines
...rdweb/Thirdweb.Transactions/ThirdwebTransaction.cs 75.67% 4 Missing and 5 partials ⚠️
...irdweb/Thirdweb.Wallets/SmartWallet/SmartWallet.cs 30.76% 1 Missing and 8 partials ⚠️
...rdweb.Wallets/PrivateKeyWallet/PrivateKeyWallet.cs 72.22% 5 Missing ⚠️
...allet/Thirdweb.AccountAbstraction/BundlerClient.cs 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #25      +/-   ##
==========================================
+ Coverage   85.98%   92.53%   +6.55%     
==========================================
  Files          18       21       +3     
  Lines        1605     1647      +42     
  Branches      156      150       -6     
==========================================
+ Hits         1380     1524     +144     
+ Misses        184       85      -99     
+ Partials       41       38       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@0xFirekeeper 0xFirekeeper changed the title Thirdweb.Http Unity Compatibility Testing Jun 5, 2024
@0xFirekeeper 0xFirekeeper changed the title Unity Compatibility Testing Compatibility & Customizeability + Various Improvements Jun 12, 2024
@0xFirekeeper 0xFirekeeper changed the title Compatibility & Customizeability + Various Improvements Unity Compatibility + Customizability + Various Improvements Jun 12, 2024
@0xFirekeeper 0xFirekeeper merged commit b22d405 into main Jun 12, 2024
1 check passed
@0xFirekeeper 0xFirekeeper deleted the firekeeper/thirdweb-http branch June 12, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants