Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Managed ZkSync Paymaster #24

Merged
merged 9 commits into from
Jun 1, 2024
Merged

Managed ZkSync Paymaster #24

merged 9 commits into from
Jun 1, 2024

Conversation

0xFirekeeper
Copy link
Member

@0xFirekeeper 0xFirekeeper commented May 29, 2024

A SmartWallet created on ZkSync and set to gasless will now automatically work in tandem with bundler/engine internally, no additional user input needed.


PR-Codex overview

This PR introduces changes related to ZkSync options, transaction handling, and InAppWallet login.

Detailed summary

  • Added ZkPaymasterDataResponse and ZkBroadcastTransactionResponse classes.
  • Updated EIP712.cs to handle zero values for Nonce and MaxPriorityFeePerGas.
  • Modified ZkSyncOptions constructor for null paymaster and paymasterInput.
  • Implemented methods for ZkPaymasterData and ZkBroadcastTransaction.
  • Enhanced transaction input validation and error handling.
  • Improved gas cost estimation for transactions.
  • Updated InAppWallet login flow logic.
  • Adjusted transaction preparation and gasless sending process.

The following files were skipped due to too many changes: Thirdweb.Console/Program.cs, Thirdweb/Thirdweb.Transactions/ThirdwebTransaction.cs, Thirdweb/Thirdweb.Wallets/SmartWallet/SmartWallet.cs

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@codecov-commenter
Copy link

codecov-commenter commented May 29, 2024

Codecov Report

Attention: Patch coverage is 68.91892% with 23 lines in your changes are missing coverage. Please review.

Project coverage is 85.98%. Comparing base (fa39694) to head (0cb1e59).

Files Patch % Lines
...allet/Thirdweb.AccountAbstraction/BundlerClient.cs 0.00% 12 Missing ⚠️
.../Thirdweb.Transactions/ThirdwebTransactionInput.cs 58.33% 4 Missing and 1 partial ⚠️
...rdweb/Thirdweb.Transactions/ThirdwebTransaction.cs 93.33% 0 Missing and 3 partials ⚠️
...SmartWallet/Thirdweb.AccountAbstraction/AATypes.cs 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #24      +/-   ##
==========================================
- Coverage   91.91%   85.98%   -5.94%     
==========================================
  Files          18       18              
  Lines        1485     1605     +120     
  Branches      138      156      +18     
==========================================
+ Hits         1365     1380      +15     
- Misses         94      184      +90     
- Partials       26       41      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@0xFirekeeper 0xFirekeeper merged commit 4c74bee into main Jun 1, 2024
1 check passed
@0xFirekeeper 0xFirekeeper deleted the firekeeper/zksync-managed branch June 1, 2024 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants