Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support 1559 and 113 (ZkSync) Transaction Types #22

Merged
merged 23 commits into from
May 23, 2024

Conversation

0xFirekeeper
Copy link
Member

@0xFirekeeper 0xFirekeeper commented May 20, 2024

PR-Codex overview

The PR focuses on enhancing transaction handling and signing in Thirdweb.

Detailed summary

  • Added ThirdwebTransactionInput class for transaction details
  • Implemented transaction signing methods
  • Introduced ZkSyncOptions for additional transaction configurations

The following files were skipped due to too many changes: Thirdweb/Thirdweb.Wallets/PrivateKeyWallet/PrivateKeyWallet.cs, Thirdweb/Thirdweb.Wallets/EIP712.cs, Thirdweb/Thirdweb.Wallets/SmartWallet/SmartWallet.cs, Thirdweb.Tests/Thirdweb.PrivateKeyWallet.Tests.cs, Thirdweb.Tests/Thirdweb.Transactions.Tests.cs, Thirdweb/Thirdweb.Transactions/ThirdwebTransaction.cs

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@0xFirekeeper 0xFirekeeper marked this pull request as draft May 20, 2024 20:29
@codecov-commenter
Copy link

codecov-commenter commented May 23, 2024

Codecov Report

Attention: Patch coverage is 84.61538% with 36 lines in your changes are missing coverage. Please review.

Project coverage is 91.33%. Comparing base (bfb46cc) to head (735ebc3).

Files Patch % Lines
...rdweb/Thirdweb.Transactions/ThirdwebTransaction.cs 73.72% 24 Missing and 7 partials ⚠️
Thirdweb/Thirdweb.Wallets/EIP712.cs 88.63% 2 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #22      +/-   ##
==========================================
- Coverage   92.35%   91.33%   -1.02%     
==========================================
  Files          16       17       +1     
  Lines        1190     1374     +184     
  Branches      116      137      +21     
==========================================
+ Hits         1099     1255     +156     
- Misses         73       94      +21     
- Partials       18       25       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@0xFirekeeper 0xFirekeeper marked this pull request as ready for review May 23, 2024 12:57
@0xFirekeeper 0xFirekeeper merged commit 1bd6acb into main May 23, 2024
1 check passed
@0xFirekeeper 0xFirekeeper deleted the firekeeper/1559-113 branch May 23, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants