Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Authenticate #18

Merged
merged 8 commits into from
May 15, 2024
Merged

Authenticate #18

merged 8 commits into from
May 15, 2024

Conversation

0xFirekeeper
Copy link
Member

@0xFirekeeper 0xFirekeeper commented Apr 20, 2024

PR-Codex overview

This PR enhances wallet authentication by adding a new method. It also introduces a utility function for generating a payload to sign.

Detailed summary

  • Added Authenticate method to IThirdwebWallet interface and PrivateKeyWallet and SmartWallet classes
  • Introduced GenerateSIWE utility function in Utils.cs
  • Added LoginPayload and LoginPayloadData classes
  • Included tests for GenerateSIWE function with different scenarios

The following files were skipped due to too many changes: Thirdweb.Tests/Thirdweb.Utils.Tests.cs, Thirdweb.Console/Program.cs

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@codecov-commenter
Copy link

codecov-commenter commented Apr 20, 2024

Codecov Report

Attention: Patch coverage is 53.60825% with 45 lines in your changes are missing coverage. Please review.

Project coverage is 92.35%. Comparing base (6768e56) to head (b019e7f).

Files Patch % Lines
...rdweb.Wallets/PrivateKeyWallet/PrivateKeyWallet.cs 0.00% 22 Missing ⚠️
...irdweb/Thirdweb.Wallets/SmartWallet/SmartWallet.cs 0.00% 22 Missing ⚠️
Thirdweb/Thirdweb.Utils/Utils.cs 97.29% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #18      +/-   ##
==========================================
- Coverage   95.79%   92.35%   -3.44%     
==========================================
  Files          15       16       +1     
  Lines        1093     1190      +97     
  Branches      103      116      +13     
==========================================
+ Hits         1047     1099      +52     
- Misses         29       73      +44     
- Partials       17       18       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@0xFirekeeper 0xFirekeeper marked this pull request as ready for review April 20, 2024 03:28
@0xFirekeeper 0xFirekeeper merged commit d0d24d7 into main May 15, 2024
1 check passed
@0xFirekeeper 0xFirekeeper deleted the firekeeper/auth branch May 15, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants