Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ThirdwebTransaction.Sign + Modify Estimation/Simulation Flows #17

Merged
merged 4 commits into from
Apr 15, 2024

Conversation

0xFirekeeper
Copy link
Member

@0xFirekeeper 0xFirekeeper commented Apr 15, 2024

PR-Codex overview

This PR enhances transaction handling in the SmartWallet and ThirdwebTransaction classes. It includes new methods for estimating gas costs, simulating transactions, and signing operations.

Detailed summary

  • Added EstimateUserOperationGas and SignTransaction methods in SmartWallet.cs.
  • Added transaction simulation and signing methods in ThirdwebTransaction.cs.
  • Expanded transaction handling in test classes.

The following files were skipped due to too many changes: Thirdweb/Thirdweb.Transactions/ThirdwebTransaction.cs

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@codecov-commenter
Copy link

codecov-commenter commented Apr 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.79%. Comparing base (dfd8bf3) to head (d400d8d).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #17      +/-   ##
==========================================
+ Coverage   95.33%   95.79%   +0.45%     
==========================================
  Files          15       15              
  Lines        1094     1093       -1     
  Branches      104      103       -1     
==========================================
+ Hits         1043     1047       +4     
+ Misses         34       29       -5     
  Partials       17       17              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@0xFirekeeper 0xFirekeeper merged commit 2bc7f65 into main Apr 15, 2024
1 check passed
@0xFirekeeper 0xFirekeeper deleted the firekeeper/simulation branch April 15, 2024 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants