Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lower Level Transaction Builder #16

Merged
merged 11 commits into from
Apr 12, 2024
Merged

Lower Level Transaction Builder #16

merged 11 commits into from
Apr 12, 2024

Conversation

0xFirekeeper
Copy link
Member

@0xFirekeeper 0xFirekeeper commented Apr 12, 2024

PR-Codex overview

This PR enhances transaction handling in Thirdweb by refactoring receipt retrieval methods and introducing a new ThirdwebTransaction class for improved readability and maintainability.

Detailed summary

  • Replaces Utils.GetTransactionReceipt with ThirdwebTransaction.WaitForTransactionReceipt
  • Introduces ThirdwebTransaction class for transaction handling
  • Updates method signatures in ThirdwebContract for better code structure

The following files were skipped due to too many changes: Thirdweb.Tests/Thirdweb.Utils.Tests.cs, Thirdweb/Thirdweb.Transactions/ThirdwebTransaction.cs, Thirdweb.Tests/Thirdweb.Transactions.Tests.cs

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@codecov-commenter
Copy link

codecov-commenter commented Apr 12, 2024

Codecov Report

Attention: Patch coverage is 92.26519% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 95.24%. Comparing base (929228f) to head (af54507).

Files Patch % Lines
...rdweb/Thirdweb.Transactions/ThirdwebTransaction.cs 91.21% 5 Missing and 8 partials ⚠️
...irdweb/Thirdweb.Wallets/SmartWallet/SmartWallet.cs 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #16      +/-   ##
==========================================
+ Coverage   95.12%   95.24%   +0.12%     
==========================================
  Files          14       15       +1     
  Lines         964     1094     +130     
  Branches       84      104      +20     
==========================================
+ Hits          917     1042     +125     
  Misses         34       34              
- Partials       13       18       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@0xFirekeeper 0xFirekeeper merged commit 130dfbd into main Apr 12, 2024
1 check passed
@0xFirekeeper 0xFirekeeper deleted the firekeeper/tx-builder branch April 12, 2024 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants