Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

private key account tests #12

Merged
merged 4 commits into from
Apr 8, 2024
Merged

private key account tests #12

merged 4 commits into from
Apr 8, 2024

Conversation

0xFirekeeper
Copy link
Member

@0xFirekeeper 0xFirekeeper commented Apr 8, 2024

PR-Codex overview

This PR enhances the PrivateKeyAccount class with improved validation and test coverage for signing transactions and data.

Detailed summary

  • Improved validation for null or empty messages in signing methods
  • Added tests for initialization, connection, signing methods
  • Enhanced error handling for different transaction types and properties

The following files were skipped due to too many changes: Thirdweb.Tests/Thirdweb.PrivateKeyAccount.Tests.cs

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@codecov-commenter
Copy link

codecov-commenter commented Apr 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.77%. Comparing base (2ff1a05) to head (caaba7f).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #12      +/-   ##
==========================================
+ Coverage   32.76%   37.77%   +5.00%     
==========================================
  Files          33       32       -1     
  Lines        2362     2197     -165     
  Branches      216      197      -19     
==========================================
+ Hits          774      830      +56     
+ Misses       1564     1353     -211     
+ Partials       24       14      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@0xFirekeeper 0xFirekeeper merged commit a195fcc into main Apr 8, 2024
1 check passed
@0xFirekeeper 0xFirekeeper deleted the firekeeper/t-pkacc branch April 8, 2024 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants