Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account Unlinking #107

Merged
merged 4 commits into from
Dec 17, 2024
Merged

Account Unlinking #107

merged 4 commits into from
Dec 17, 2024

Conversation

0xFirekeeper
Copy link
Member

@0xFirekeeper 0xFirekeeper commented Dec 17, 2024

Closes CNCT-2627


PR-Codex overview

This PR focuses on implementing the UnlinkAccount functionality across various wallet classes, enhancing the account management capabilities of the Thirdweb wallet system.

Detailed summary

  • Added UnlinkAccount method to PrivateKeyWallet with an exception message.
  • Defined UnlinkAccount in IThirdwebWallet interface with XML documentation.
  • Updated LinkedAccount struct in InAppWallet.Types.cs to include JSON properties.
  • Implemented UnlinkAccount in SmartWallet, checking for wallet types.
  • Added UnlinkAccountAsync in EmbeddedWallet for server-side unlinking.
  • Implemented UnlinkAccount in EcosystemWallet, ensuring the wallet is connected.
  • Enhanced ServerBase with UnlinkAccountAsync method for server interaction.
  • Updated commented-out code in Program.cs to demonstrate unlinking functionality.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

linear bot commented Dec 17, 2024

@codecov-commenter
Copy link

codecov-commenter commented Dec 17, 2024

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 77.96%. Comparing base (429187d) to head (de8b8ad).

Files with missing lines Patch % Lines
...irdweb/Thirdweb.Wallets/SmartWallet/SmartWallet.cs 0.00% 7 Missing ⚠️
...rdweb.Wallets/PrivateKeyWallet/PrivateKeyWallet.cs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #107      +/-   ##
==========================================
- Coverage   78.23%   77.96%   -0.27%     
==========================================
  Files          28       28              
  Lines        4488     4497       +9     
  Branches      619      620       +1     
==========================================
- Hits         3511     3506       -5     
- Misses        812      826      +14     
  Partials      165      165              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@0xFirekeeper 0xFirekeeper merged commit b0631e7 into main Dec 17, 2024
1 check passed
@0xFirekeeper 0xFirekeeper deleted the firekeeper/account-unlinking branch December 17, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants