Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SmartWallet] Fix SwitchNetwork from zksync stack to non zksync #106

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

0xFirekeeper
Copy link
Member

@0xFirekeeper 0xFirekeeper commented Dec 9, 2024

PR-Codex overview

This PR focuses on enhancing the SmartWallet functionality by improving contract initialization based on the entry point version and adding new test cases for multi-chain transactions.

Detailed summary

  • Refactored contract initialization in SmartWallet.cs to use var for entryPointAbi and factoryAbi.
  • Removed redundant contract creation calls.
  • Added new test cases in Thirdweb.SmartWallet.Tests.cs for:
    • Multi-chain transaction success.
    • Multi-chain transaction from zk to non-zk.
    • Multi-chain transaction from non-zk to zk.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.23%. Comparing base (777f232) to head (3264b91).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #106      +/-   ##
==========================================
+ Coverage   78.16%   78.23%   +0.06%     
==========================================
  Files          28       28              
  Lines        4488     4488              
  Branches      619      619              
==========================================
+ Hits         3508     3511       +3     
+ Misses        814      812       -2     
+ Partials      166      165       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@0xFirekeeper 0xFirekeeper merged commit 671ef84 into main Dec 9, 2024
1 check passed
@0xFirekeeper 0xFirekeeper deleted the firekeeper/zk-nonzk-switch branch December 9, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants