Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contract tests #10

Merged
merged 3 commits into from
Apr 8, 2024
Merged

contract tests #10

merged 3 commits into from
Apr 8, 2024

Conversation

0xFirekeeper
Copy link
Member

@0xFirekeeper 0xFirekeeper commented Apr 8, 2024

PR-Codex overview

This PR focuses on enhancing Thirdweb's smart contract interactions by introducing private key accounts, updating contract interactions, and adding test cases for contract initialization and read/write operations.

Detailed summary

  • Added PRIVATE_KEY secret to CI workflow
  • Updated PrivateKeyAccount to handle private key accounts
  • Updated SmartAccount with default entry point address
  • Added PRIVATE_KEY environment variable in tests
  • Modified contract transactions based on account type
  • Added contract interaction tests for different scenarios

The following files were skipped due to too many changes: Thirdweb.Tests/Thirdweb.Contracts.Tests.cs

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@codecov-commenter
Copy link

codecov-commenter commented Apr 8, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 28.33%. Comparing base (591cea1) to head (5d68451).

Files Patch % Lines
Thirdweb/Thirdweb.Contracts/ThirdwebContract.cs 70.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main      #10       +/-   ##
===========================================
+ Coverage   14.12%   28.33%   +14.21%     
===========================================
  Files          33       33               
  Lines        2365     2361        -4     
  Branches      217      216        -1     
===========================================
+ Hits          334      669      +335     
+ Misses       2029     1671      -358     
- Partials        2       21       +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@0xFirekeeper 0xFirekeeper merged commit 83c9d89 into main Apr 8, 2024
1 check passed
@0xFirekeeper 0xFirekeeper deleted the firekeeper/t-contracts branch April 8, 2024 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants