-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Playwright GH Action #364
Conversation
2fc6c2f
to
0959d55
Compare
- uses: actions/checkout@v3 | ||
- uses: actions/setup-node@v3 | ||
- uses: actions/checkout@v4 | ||
- uses: actions/setup-node@v4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I minor, but important, upgrade I think people often forget to do. 👍
with: | ||
name: playwright-report | ||
path: ./client/playwright-report/ | ||
retention-days: 30 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not for this PR (unless you want it to be), but one issue I observed the other day on a project was that the deployment failed and so we skipped running Playwright because github.event.deployment_status.state
did not equal success. But the PR was still green because of the previous playwright run.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, makes sense. I will move this to GH issue for later.
What this does
Playwright E2E tests are failing in CI on my newly-bootstrapped project with the error below.
I don't think the error is important. I believe the root cause is a working directory issue. This updates the GH Action config with working directory changes that have worked on other projects.
The error: