Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Playwright GH Action #364

Merged
merged 3 commits into from
Nov 12, 2024
Merged

Fix Playwright GH Action #364

merged 3 commits into from
Nov 12, 2024

Conversation

whusterj
Copy link
Member

@whusterj whusterj commented Nov 9, 2024

What this does

Playwright E2E tests are failing in CI on my newly-bootstrapped project with the error below.

I don't think the error is important. I believe the root cause is a working directory issue. This updates the GH Action config with working directory changes that have worked on other projects.

The error:

SyntaxError: /Users/william/thinknimble/darksaber/client/src/components/HelloWorld.vue: Adjacent JSX elements must be wrapped in an enclosing tag. Did you want a JSX fragment <>...</>? (79:0)

  77 | </template>
  78 |
> 79 | <script>
     | ^
  80 | export default {
  81 |   name: 'HelloWorld',
  82 |   props: {

   at client/tests/unit/example.test.ts:79

@whusterj whusterj self-assigned this Nov 9, 2024
@oudeismetis oudeismetis temporarily deployed to tn-spa-bootstrapper-pr-364 November 9, 2024 19:33 Inactive
@oudeismetis oudeismetis temporarily deployed to tn-spa-bootstrapper-pr-364 November 9, 2024 19:36 Inactive
@oudeismetis oudeismetis temporarily deployed to tn-spa-bootstrapper-pr-364 November 9, 2024 19:45 Inactive
@oudeismetis oudeismetis force-pushed the fix-playwright-gh-action branch from 2fc6c2f to 0959d55 Compare November 12, 2024 14:23
@oudeismetis oudeismetis temporarily deployed to tn-spa-bootstrapper-pr-364 November 12, 2024 14:23 Inactive
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I minor, but important, upgrade I think people often forget to do. 👍

with:
name: playwright-report
path: ./client/playwright-report/
retention-days: 30
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not for this PR (unless you want it to be), but one issue I observed the other day on a project was that the deployment failed and so we skipped running Playwright because github.event.deployment_status.state did not equal success. But the PR was still green because of the previous playwright run.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, makes sense. I will move this to GH issue for later.

@whusterj whusterj merged commit 38bb4aa into main Nov 12, 2024
18 checks passed
@whusterj whusterj deleted the fix-playwright-gh-action branch November 12, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants