Decouple session management of tokens from user data #354
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this does
Our current implementation is fine, but becomes a problem the moment you want to update the users stored info without also updating their token.
Current client statuses
Main problem is Vue.
Both React and React Native, don't depend on the user model for getting the token. Upon authentication we set the token in store as well as the userId.
Therefore the userId is used to fetch the user information with
users/{userid}
However, since the user is returned by the auth call, we save that information in the query cache to avoid needing to call this endpoint, but the source of truth for the user information is always the server and not the store.
Checklist
How to test
Add user steps to achieve desired functionality for this feature.