Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove jinja2-time from _extensions #350

Merged
merged 3 commits into from
Sep 5, 2024
Merged

Remove jinja2-time from _extensions #350

merged 3 commits into from
Sep 5, 2024

Conversation

whusterj
Copy link
Member

@whusterj whusterj commented Sep 5, 2024

What this does

According to cookiecutter/cookiecutter#1888, the jinja2-time extension is no longer required and can be removed. In more recent versions of cookiecutter, the time extension is loaded automatically.

This should make it possible to run the bootstrapper with the following commands. pipx is recommended by cookiecutter's docs:

brew install pipx
pipx install cookiecutter
pipx run cookiecutter gh:thinknimble/tn-spa-bootstrapper

@whusterj whusterj requested a review from oudeismetis September 5, 2024 19:13
@whusterj whusterj self-assigned this Sep 5, 2024
@whusterj whusterj requested a review from paribaker September 5, 2024 19:14
@oudeismetis oudeismetis temporarily deployed to tn-spa-bootstrapper-pr-350 September 5, 2024 19:16 Inactive
@whusterj whusterj temporarily deployed to tn-spa-bootstrapper-pr-350 September 5, 2024 19:18 Inactive
@whusterj whusterj temporarily deployed to tn-spa-bootstrapper-pr-350 September 5, 2024 19:24 Inactive
@whusterj
Copy link
Member Author

whusterj commented Sep 5, 2024

Tests are passing and it appears to be working locally.

Tested with:

brew install pipx

pipx install cookiecutter
pipx run cookiecutter https://github.com/thinknimble/tn-spa-bootstrapper.git --checkout remove-jinja2-time

@whusterj whusterj merged commit 7c23c32 into main Sep 5, 2024
17 of 18 checks passed
@whusterj whusterj deleted the remove-jinja2-time branch September 5, 2024 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants