-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Automated Expo PR Builds #340
Open
paribaker
wants to merge
68
commits into
main
Choose a base branch
from
feature/add-expo-builds-pr
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
68 commits
Select commit
Hold shift + click to select a range
0493676
feat: expo upgrade
lakardion 27ab9ac
Merge remote-tracking branch 'origin/main' into feature/expo-upgrade-50
lakardion c2a9710
feat(mobile) env variables and Nativewind v4
lakardion c53d665
chore(mobile) deprecate sentry-expo in favor of @sentry/react-native
lakardion 1de7c96
chore: add metro config and unignore
lakardion 06d1f52
Merge branch 'main' into feature/expo-upgrade-50
paribaker eebe320
update the bootstrapper pipeline to force the use of a new config
paribaker 70d1063
merged main
2821356
fix vars
f5edc9b
fix conflict
bb3054c
updated the script to work from within the bs app
ef6c7a1
cp files run script
e1bceb9
fix directory issues
a4debde
remove unnecessary step
73b5002
try new dir
c48b69b
try new dir
4105a35
fix dir after switch
870cae4
checking again
0b11171
attempt #2
0d58905
check if script is running
f30419b
trying to see error
a956ec5
utypo
33dcde4
try and see output
f3a759f
try logs
5f3c0b3
check each var
19c4e8b
check each var
5b29825
clean up and move
7344ffd
skip if no var exists
d807245
confirm files
1e421ee
replaced original configs
7857661
updated the pipeline to use a newer version
3e9b3c9
change the directories
8376b18
not finding the configs
1f73d70
not finding the configs
0479a28
see cwd
ac1c91f
updated cwd
e57936f
fix dirs
b38b7aa
hard code dir
2289708
cwd
0519866
missing var
767f03e
remove logs add debugger
485952c
reset var on exit and default to es
bd639ce
switch to node instead of yarn
fdb343a
fix cache
6c75751
updated to remove cache
476ddf9
added cache
261d614
update names and readme
e2afa80
removed comment
8ef69ea
add dynamic PR builds
70fb752
updated the echo
72e4c2e
regex to get PR number
3417a66
forgot url
3f4fe15
added sheet with vars
0ad55e2
added vars sheet
9a5ebf9
updated app
5f5fdbd
updated to echo output
7ff342f
fix typo and set vars in one line
18f8ba9
try with vars again
68068fa
added missing echo
d58fe09
updated channels
a11d780
merged main
fd8e7c6
remove outputs as it is depcrecated
c369149
test with build
010c2f0
fix binding for channel
29629b5
fix binding for channel
d891503
fix env var
e01f729
fix build command
0528658
check if the issue is related to the profile
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -14,5 +14,5 @@ REPLACE_WITH_APPSTORE_CONNECT_APP_NAME=TN Bootsrapper RN | |
[email protected] | ||
REPLACE_WITH_APPLESTORE_CONNECT_ID=6446805695 | ||
REPLACE_WITH_APPLE_TEAM_ID=6BNA6HFF6B | ||
REPLACE_WITH_REVIEW_APP_SENTRY_PROJECT_NAME=tn-bootsrapper-rn | ||
REPLACE_WITH_REVIEW_APP_SENTRY_PROJECT_NAME=tn-spa-staging | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One thought I had was, if we remove the channel here will we be able to use the statically defined config instead of dynamically creating a new entry?
The reason we are adding this entry is so that there will be a unique build for this PR that does not affect other PR's. However since this one is built on the fly in order to test it the user will have to:
Register their device, and update the cert to and then rebuild.