add axios error handler that handles drf messages #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lakardion
reviewed
Aug 6, 2024
| @@ -0,0 +1,23 @@ | |||
| import { isAxiosError, AxiosError } from 'axios' | |||
|
|
|||
| export function handleDRFAPIErrorsOrReThrow(error: AxiosError | Error): string[]{ | |||
There was a problem hiding this comment.
AxiosError type is inferred by the isAxiosError assert function on it's own, no need to declare it at all
Comment on lines
+5
to
+7
| const e: AxiosError = error | ||
|
|
||
| const { data } = (e as AxiosError)?.response ?? null |
There was a problem hiding this comment.
I don't think you need to cast here. In neither of the two lines
| } | ||
| return [] | ||
| } | ||
| throw error as Error |
There was a problem hiding this comment.
Not sure whether the cast does anything at all here 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this does
Add a description of what feature/page this PR intends to add or change.
Checklist
How to test
Add user steps to achieve desired functionality for this feature.