Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPM Restructure and Bug Fix where Font path was coming as nil #275

Merged
merged 3 commits into from
Jan 30, 2022

Conversation

sandeepbol
Copy link
Contributor

Precisely the fix for --
#248

@dneykov
Copy link

dneykov commented Jan 25, 2022

Any idea when this can be merged? I can confirm SPM works!

Only thing that I see is the following warning:
'tools' was identified as an executable target given the presence of a 'main.swift' file. Starting with tools version 5.4.0 executable targets should be declared as 'executableTarget()'

Edit: Replacing .target( in Package.swift:19 with .executableTarget( fixes the warning.

@MatrixSenpai MatrixSenpai merged commit 26d6f41 into thii:master Jan 30, 2022
@sandeepbol
Copy link
Contributor Author

@MatrixSenpai Please create a release tag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants