Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak main-column styling #5

Open
wants to merge 3 commits into
base: devel
Choose a base branch
from
Open

Conversation

bengott
Copy link
Contributor

@bengott bengott commented Sep 26, 2016

I think this looks cleaner.. Removed the offset light purple top left corner and instead made it plain white and flush with the left edge of the main column.

I think this looks cleaner.. Removed the offset light purple top left corner and instead made it plain white and flush with the left edge of the main column.
@queso
Copy link
Member

queso commented Sep 26, 2016

Interesting, have a screenshot of the change? I can play with it later tonight if I get a minute, but if you gimme a screenshot, I could merge and deploy sooner 💃

@bengott
Copy link
Contributor Author

bengott commented Sep 26, 2016

Before:
before

After:
after

@bengott
Copy link
Contributor Author

bengott commented Sep 26, 2016

(makes the top left corner the same as the top right corner) :)

@queso
Copy link
Member

queso commented Sep 26, 2016

Oh, I see. So you don't like the scrolling fax paper feel that @SachaG was going for? Let me think on this.

@bengott
Copy link
Contributor Author

bengott commented Sep 26, 2016

Ohh, I see it now.. But yeah, that was not obvious to me. It just looks uneven and weird, like an offset purple circle on top of a white background (which is of course what it is). Maybe it would look better with some shading? No offense, @SachaG. ;)

@nickredmark
Copy link

I saw what it was meant to be, but still prefer @bengott version

@SachaG
Copy link
Collaborator

SachaG commented Sep 30, 2016

@queso feel free to call the shot on this one, I won't be mad if you decide to get rid of my uber-cool 3D effect :)

@andrewjrhill
Copy link

andrewjrhill commented Oct 8, 2016

I must say, I am in favour of ditching the::before and ::after bits all-together. In my own opinion, it does look cleaner without the psuedo-elements.

screen shot 2016-10-08 at 8 09 51 pm

@bengott
Copy link
Contributor Author

bengott commented Oct 11, 2016

@sntax I dig it. Submit a PR to my fork?

@andrewjrhill
Copy link

@bengott - sure thing, ill take a look at it tonight.

@andrewjrhill andrewjrhill mentioned this pull request Oct 11, 2016
Remove "folding paper" styles from main element
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants