Remove empty "test" #15
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm generally opposed to silencing a warning by adding a dummy block that expressly does *not* do what the warning recommends. If there's no way to test this, then the warning is correct: there's no test. If there is a way to test this, then adding "true" is not a good test. # Conflicts: # Formula/ssh-askpass.rb
|
I tried to do what you suggests by executing two parallel scripts but couldn't get it to work. Not sure which window/dialog to aim for and it seems like it requires Accessibility permissions which I think gets a lot more overhead then we want. Since this PR no longer can get merged with out conflict I suggest that we leave the code as is until someone can create a real test. |
|
I'll try to write something up. I think it'll boil down to: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm generally opposed to silencing a warning by adding a dummy block that expressly does not do what the warning recommends. If there's no way to test this, then the warning is correct: there's no test. If there is a way to test this, then adding "true" is not a good test.
Some possible options to write a good test:
osascriptruns?Here's an idea: asynchronously run ssh-askpass with known inputs, then run a second
osascriptwhich passes "enter" or clicks "OK" to the waiting window, then validate the return value.