-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Owner limit bypass #1621
Open
wojciech-turek
wants to merge
7
commits into
add-wave-mint-event
Choose a base branch
from
owner-limit-bypass
base: add-wave-mint-event
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Owner limit bypass #1621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
capedcrusader21
approved these changes
Jan 15, 2025
@@ -102,6 +80,10 @@ contract NFTCollection is | |||
* @notice stores the personalization mask for a tokenId | |||
*/ | |||
mapping(uint256 => uint256) personalizationTraits; | |||
/** | |||
* @notice stores the number of tokens minted by an address |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minted by an address or minted for an address?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"minted by" is the correct one
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We have identified a couple issues that we had to address:
waveTotalMinted
as that limit should be for regular user mintsThis PR contains the logic that is supposed to solve the above issues by:
maxTokensPerWallet
measured inmintedCount
per walletmint
andwaveMint
but notbatchMint
which is the owner function.waveMaxTokensPerWallet
higher thanmaxTokensPerWallet
as that would make no sense.maxTokensPerWallet
is1
to have two waves withwaveMaxTokensPerWallet
set to1
also as we may let users chose the mint wave.Other changes:
WaveMint
event