-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Land Sale Package #1612
Open
capedcrusader21
wants to merge
10
commits into
master
Choose a base branch
from
feat/land-sale-package
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Land Sale Package #1612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Land Sale Package
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
capedcrusader21
force-pushed
the
feat/land-sale-package
branch
from
November 11, 2024 12:02
e602d76
to
154fc72
Compare
capedcrusader21
force-pushed
the
feat/land-sale-package
branch
9 times, most recently
from
November 21, 2024 14:57
7a58b85
to
f33bda4
Compare
wojciech-turek
requested changes
Dec 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor comments after which I think we can give this a go!
packages/deploy/deploy/1000_landsale/1000_deploy_estate_sale.ts
Outdated
Show resolved
Hide resolved
capedcrusader21
force-pushed
the
feat/land-sale-package
branch
from
December 6, 2024 08:55
c867030
to
81ebd76
Compare
capedcrusader21
force-pushed
the
feat/land-sale-package
branch
from
December 16, 2024 12:27
5c72035
to
f51f2cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Created a new package for Land-Sale contract.
moved land-sale scripts to deploy package.