Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Land Sale Package #1612

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Land Sale Package #1612

wants to merge 10 commits into from

Conversation

capedcrusader21
Copy link
Contributor

Description

  • Created a new package for Land-Sale contract.

  • moved land-sale scripts to deploy package.

Copy link

openzeppelin-code bot commented Oct 29, 2024

Land Sale Package

Generated at commit: 154fc72116bb41174977f025817a2b1384e48ac1

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total
3
1
0
6
28
38

For more details view the full report in OpenZeppelin Code Inspector

@capedcrusader21 capedcrusader21 force-pushed the feat/land-sale-package branch 9 times, most recently from 7a58b85 to f33bda4 Compare November 21, 2024 14:57
@capedcrusader21 capedcrusader21 marked this pull request as ready for review November 28, 2024 07:49
@capedcrusader21 capedcrusader21 requested a review from a team as a code owner November 28, 2024 07:49
Copy link
Member

@wojciech-turek wojciech-turek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments after which I think we can give this a go!

packages/deploy/land-sale-artifacts/deadlines.ts Outdated Show resolved Hide resolved
packages/land-sale/README.md Outdated Show resolved Hide resolved
packages/land-sale/README.md Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants