Skip to content

Commit

Permalink
fix: fixed require with multiple condition
Browse files Browse the repository at this point in the history
  • Loading branch information
capedcrusader21 committed Sep 16, 2024
1 parent e6628ba commit b60a28b
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion packages/marketplace/contracts/ExchangeCore.sol
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,8 @@ abstract contract ExchangeCore is Initializable, ITransferManager {
uint256 rightOrderFill = _getOrderFill(orderRight.salt, orderKeyHashRight);
newFill = LibOrder.fillOrder(orderLeft, orderRight, leftOrderFill, rightOrderFill);

require(newFill.rightValue > 0 && newFill.leftValue > 0, "nothing to fill");
require(newFill.rightValue > 0, "nothing to fill");
require(newFill.leftValue > 0, "nothing to fill");

if (orderLeft.salt != 0) {
fills[orderKeyHashLeft] = leftOrderFill + newFill.rightValue;
Expand Down

1 comment on commit b60a28b

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coverage for this commit

98.21%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
packages/marketplace/contracts
   Exchange.sol94.52%93.33%94.44%96%127, 195, 73
   ExchangeCore.sol97.75%93.75%100%100%199, 81
   OrderValidator.sol98.44%96.15%100%100%36
   RoyaltiesRegistry.sol96.32%88.89%100%98.78%194, 216–217, 263, 65
   TransferManager.sol96.04%87.50%100%99.41%163, 225, 247, 333, 393, 430, 581, 586, 597, 619, 93
   Whitelist.sol75.81%60%85.71%82.14%105, 109–110, 123, 126, 142–143, 55, 67, 67–68, 72, 77
packages/marketplace/contracts/interfaces
   IOrderValidator.sol100%100%100%100%
   IRoyaltiesProvider.sol100%100%100%100%
   ITransferManager.sol100%100%100%100%
   IWhitelist.sol100%100%100%100%
packages/marketplace/contracts/libraries
   LibAsset.sol100%100%100%100%
   LibMath.sol100%100%100%100%
   LibOrder.sol100%100%100%100%

Please sign in to comment.