Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New layer option: noLayerMeta #36

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

thoechsmann
Copy link

I added new layer option allowing to not create any meta data for a specific layer.

Similar to ignoreAllNamesWithBlank, but for layers.

I did this intentionally with a json setting instead of a file name filter as the former is much cleaner. I would vote for moving all config into the json and not use the filename for this at all.

layersOrder: [
      { name: "Background",
        options: { noLayerMeta: true }
      },
    ],

I added new layer option allowing to not create any meta data for that layer.

Similar to ignoreAllNamesWithBlank, but for layers.

I did this intentionally with a json setting instead of a file name filter as the former is much cleaner. I would vote for moving all config into the json and not use the filename for this at all.
@thoechsmann thoechsmann changed the title Update main.js New layer option: noLayerMeta Mar 16, 2022
@thepeanutgalleryandco
Copy link
Owner

I would vote for moving all config into the json and not use the filename for this at all.
Can you please clarify what exactly you mean with this?

When or how would you like to use this / Is this a real use-case? Usually, people just don't the empty layer item in the filename, I haven't seen complete folders being omitted before.

@thoechsmann
Copy link
Author

its again about a bit confusing/inconsistent configuration. Some in src/config (I normally would never look into src to configure anything) some in layers, some in constants. To add more to the confusion, layer settings are done in the config.js while item config is done through the name of a file.

@thepeanutgalleryandco
Copy link
Owner

Understood, thanks for the clarification.

With regards to the use-case, can you check this out - "When or how would you like to use this / Is this a real use-case? Usually, people just don't the empty layer item in the filename, I haven't seen complete folders being omitted before."

Do you have layers that you would like to use in your base, but then would not like them to be added to the metadata? What would the reasoning be for this? I haven't come across this use-case with anyone in the past 4 months, so its an interesting use-case.

@thoechsmann
Copy link
Author

If you have a trait that is rendered on several layers you want the trait to be just shown once in the meta data.

@Deathwing Deathwing deleted the noLayerMeta2 branch August 2, 2022 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants