add memory cert reloader #517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maditya
reviewed
Nov 7, 2024
| @@ -0,0 +1,2 @@ | |||
| Copyright 2024 Yahoo Inc. | |||
There was a problem hiding this comment.
was this mistakenly checked in?
There was a problem hiding this comment.
It's the license file for https://github.com/google/addlicense. I'll add a comment in the readme.
maditya
approved these changes
Nov 7, 2024
maditya
reviewed
Nov 7, 2024
| // Copyright 2024 Yahoo Inc. | ||
| // Licensed under the terms of the Apache License 2.0. Please see LICENSE file in project root for terms. | ||
|
|
||
| package utils |
There was a problem hiding this comment.
can we call this certreload?
There was a problem hiding this comment.
sure, I'll change it in the next PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR introduces memory cert reloader for mTLS between crypki otel exporter and otel collector.
Blocks #515
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.