-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed non notched window size on notched devices when sideloading an app #31
base: master
Are you sure you want to change the base?
Conversation
⇝ replaces UILaunchImageFile with UILaunchStoryboardName
Doesn't this remove backward compatibility? Will it be better to add a separate template for building apps on modern OS versions using Theos? |
Well I guess yeah, is it worth it though? There’s probably not many people making apps for < iOS 9, which is less common than tweaks, otherwise two new templates would’ve to be made for both Objective-C and Swift, but sure that’s also a solution |
I'd argue against modifying the current templates as-is w/o adding legacy counterparts as targeting legacy iOS versions is still a supported use case for Theos. That being said, it does seem a bit much to add two new templates -- one for the ObjC app and one for the Swift -- with only an Info.plist change. Do we think it would be worthwhile to simply comment out the 'legacy' implementation, with a short message describing when you'd want to uncomment it, and add the changes proposed here? |
No, comments in plists are not well supported and we should avoid this. Also, I feel like it does not provide a great user experience in my opinion. |
Fair enough. So does out-of-the-box legacy support take priority over sideloading support or do we want to add a couple "legacy"/"modern" templates? I'm kinda leaning towards the priority scenario personally |
Idk, as you said providing new templates with just an |
Hm. I think we have three options assuming we don't go with additional templates:
I am sort of leaning toward one of the first two, but open to hear others' thoughts. |
I'd go with either 2 of 3 if it were me |
What does this implement/fix? Explain your changes.
See title. This happened because the way the system detects the resolution of the iPhone changed starting from xcode 6/7 and iOS 9. Now a
UILaunchStoryboardName
key in theInfo.plist
is needed instead of a bunch of png files. Relevant sources:◦ Source
◦ Source 2
Does this close any currently open issues?
Any relevant logs, error output, etc?
Any other comments?
Where has this been tested?
Operating System: Kubuntu 22.04.2 LTS x86_64
Platform: Linux
Target Platform: iOS
Toolchain Version: Swift 5.7.2
SDK Version: 15.5