-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: exclusive 'or' checklist with grouped options #4116
Open
jamdelion
wants to merge
18
commits into
main
Choose a base branch
from
jh/grouped-checklist-with-or-2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+800
−377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamdelion
changed the title
feat: grouped checklists 2
feat: exclusive 'or' checklist with grouped options
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR:
This is version 2 of handling expanded/grouped checklists with an exclusive 'or' option! Originally I had it nested in each grouped checklist. Based on slack feedback, now there is just one exclusive 'or' option at the bottom of all the groups.
🎟️ https://trello.com/c/dXUW9EC1/3146-add-or-option-to-checklists
Overall this component has been complex to work with! There is certainly a lot more to be done to make it easier and more readable. This PR is big so that the editor and public facing changes to the grouped scenario could be done at once.
Done:
VisibleChecklist
into two separate Checklist types:GroupedChecklist
andChecklist
, which each manage their ownformik
state.useInitialOptions
to replicate what Jess did in a previous PR for now, across the refactoredOptions
components.Styling thoughts 🎨
ListManager
so I have not implemented this.