feat: add has_send_component to flows table
#4113
Conversation
hasura.planx.uk/migrations/1736253268324_add_has_data_to_flows/up.sql
Outdated
Show resolved
Hide resolved
hasura.planx.uk/migrations/1736253268324_add_has_data_to_flows/up.sql
Outdated
Show resolved
Hide resolved
hasura.planx.uk/migrations/1736253268324_add_has_data_to_flows/up.sql
Outdated
Show resolved
Hide resolved
| @@ -0,0 +1,2 @@ | |||
| alter table "public"."published_flows" add column "has_send_component" boolean | |||
There was a problem hiding this comment.
the default false hopefully ensures it's false always and I don't need to populate everything
There was a problem hiding this comment.
nit: I don't mean this to sound harsh, but I find comments like this quite confusing to review - are you confident that default 'false' works as you expect it to (based on your local env and how pizza built) or are you asking an implementation question that you'd like a second opinion on?
"Hopefully ensures" sounds like you're not confident in what you've done here and also have not double-checked the pizza's published_flows table to confirm, which is not the right attitude for database migrations !!
There was a problem hiding this comment.
Nah not harsh at all! I was planning to come back with confirmation that it was all good, apologies for the nature of the changes / issues on this one. Thanks for giving feedback even when you think it's harsh, always really appreciate it
hasura.planx.uk/migrations/1736253268324_add_has_data_to_flows/up.sql
Outdated
Show resolved
Hide resolved
|
🤖 Hasura Change Summary compared a subset of table metadata including permissions: Updated Tables (1)
|
| AS $function$ | ||
| WITH current_published_flow as ( | ||
| SELECT | ||
| id, data, created_at, flow_id, publisher_id, summary, has_send_component |
| @@ -0,0 +1,2 @@ | |||
| alter table "public"."published_flows" add column "has_send_component" boolean | |||
There was a problem hiding this comment.
nit: I don't mean this to sound harsh, but I find comments like this quite confusing to review - are you confident that default 'false' works as you expect it to (based on your local env and how pizza built) or are you asking an implementation question that you'd like a second opinion on?
"Hopefully ensures" sounds like you're not confident in what you've done here and also have not double-checked the pizza's published_flows table to confirm, which is not the right attitude for database migrations !!
What does this PR do?
To support the work on organising flows, we want to try understand which services are Submission and which are Guidance. One tactic for this is to look for a
Sendcomponent in the flow data. This would say that this services submits data rather than providing guidance.Linked to this Trello tick: https://trello.com/c/7av8lsVr/3160-epic-as-an-editor-i-want-to-have-a-way-to-organise-my-flows-so-that-i-can-easily-find-what-im-looking-for