feat(fee-breakdown): Display for "invite to pay" journeys #4057
Conversation
|
🤖 Hasura Change Summary compared a subset of table metadata including permissions: Updated Tables (1)
|
|
Removed vultr server and associated DNS entries |
| hideFeeBanner={true} | ||
| paymentStatus={payment?.state.status} | ||
| /> | ||
| </> |
There was a problem hiding this comment.
nit: I think this should be feature-flagged ? I can see a breakdown here with & without feature flag: https://4057.planx.pizza/barnet/invite-to-pay-test/pay?paymentRequestId=f0babfb3-4a57-4c01-bdc2-cd344bac865c
Also, minor style nitpick: should we remove "Fee" line from top table, and then simply call bottom part "Fee" instead of "Fee breakdown" ?
There was a problem hiding this comment.
Also, do we need to account for any active invitations that won't have saved breakdown details when this merges? Will the breakdown simply not display/be hidden?
There was a problem hiding this comment.
Yep - feature flag should be here thanks!
Changed from "Fee breakdown" to "Fee".
This will just not show at all if there's no fee breakdown, so we should be ok for that transition period 👍
I'd love a pass over this page by Ian at some point also - the two tables, one horizontal and one vertical just feel a bit weird back to back here.
| @@ -0,0 +1,2 @@ | |||
| alter table "public"."payment_requests" add column "fee_breakdown" jsonb | |||
| null; | |||
What does this PR do?
✅ Regression tests passing here https://github.com/theopensystemslab/planx-new/actions/runs/12238473625