fix: Convert Digital Planning payload to JSON file before upload #4054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
DafyddLlyr
changed the title
|
Removed vultr server and associated DNS entries |
DafyddLlyr
force-pushed
the
dp/file-upload-typechecking
branch
from
80aa9a8 to
ea7a7a3
Compare
jessicamcinchak
approved these changes
Dec 9, 2024
There was a problem hiding this comment.
Thanks for picking this up 👍
Pizza working as expected & JSON file is populated: https://4054.planx.pizza/barnet/test/submissions-log
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
DigitalPlanningPayloadto anExpress.Multer.Filefor uploadComments
Trickier than expected! TypeScript isn't catching the mismatch between
DigitalPlanningPayloadandExpress.Multer.Fileeven when the type is imported and assigned. I think it's to do with the combination of the type complexity plus theAwaited<>utility type which has a depth limit I believe.Next up is some tests here for the entire module (in another PR), will also check the Pizza to make this is working as expected once it's up.