style: Improve legibility of dot labels #507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for oslmap ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
DafyddLlyr
approved these changes
Oct 21, 2024
jessicamcinchak
requested changes
Oct 21, 2024
There was a problem hiding this comment.
Hi ! I think this looks great for drawMany cases when labels are visible - but can we please confirm this is still the intended style for:
- drawing a single point
drawManywithhideDrawLabelsas recently introduced in feat: showLabel prop added #508
I think I'd still expect to still see a solid colored point in these cases rather than the stroke only?
ianjon3s
force-pushed
the
ian/dot-marker-label-contrast-improve
branch
from
13ae4b1 to
e28c6c8
Compare
|
Good point @jessicamcinchak , however we still want to show two contrasting colours to safeguard against any contrast issues with the background map (green on green < green+white on green). I've updated the stroke to be thicker in the absence of labels: 
|
jessicamcinchak
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Improves visibility of point labels by removing character stroke and keeping background/text colour constant (not dependent on custom colour selection).
Preview (before vs after):
