fix: ensure drawMany feature labels are incremental

[jessicamcinchak]

Flagged while testing drawMany

I honestly don't fully understand what was happening here, but my best guess is that is has to do with how OpenLayer's change event listens to more internal events than just adding features as we see them on the map, therefore anything called in this block may be firing off more often than we expect?

Setting the label based on the current length of all features, rather than an index of the one we're iterating over, seems to do the trick - labels are consistently incrementing by one now!

[netlify]

✅ Deploy Preview for oslmap ready!

Name	Link
🔨 Latest commit	35a72e8
🔍 Latest deploy log	https://app.netlify.com/sites/oslmap/deploys/66d89053d5a941000861e99d
😎 Deploy Preview	https://deploy-preview-495--oslmap.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[jamdelion]

Flagged while testing drawMany

I honestly don't fully understand what was happening here, but my best guess is that is has to do with how OpenLayer's change event listens to more internal events than just adding features as we see them on the map, therefore anything called in this block may be firing off more often than we expect?

Setting the label based on the current length of all features, rather than an index of the one we're iterating over, seems to do the trick - labels are consistently incrementing by one now!

Might be worth making this gif bigger, I can't really see what's happening in it!

[jessicamcinchak]

@jamdelion yes sorry know it's tiny - GitHub kept rejecting other versions because too big file size !

Other best way to test changes in this repo is:

• Go to Netlify deploy of Pitsy docs
• Open an "interactive playground" for map & directly adjust props there & test!