Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: increase drawMany label font size and default drawing point size #483

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

jessicamcinchak
Copy link
Member

After screenshots:
Screenshot from 2024-08-29 12-37-21
Screenshot from 2024-08-29 12-35-56

Copy link

netlify bot commented Aug 29, 2024

Deploy Preview for oslmap ready!

Name Link
🔨 Latest commit 3766ed9
🔍 Latest deploy log https://app.netlify.com/sites/oslmap/deploys/66d05173b6f1d400081c82be
😎 Deploy Preview https://deploy-preview-483--oslmap.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@@ -69,14 +69,14 @@ function getVertices(drawColor: string) {
function styleFeatureLabels(drawType: DrawTypeEnum, feature: FeatureLike) {
return new Text({
text: feature.get("label"),
font: "80px inherit",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Realised "inherit" actually isn't supported here, so was just falling back to the OL default - hence 20px change is actually bigger than original 80px defined here 🙈

@jessicamcinchak jessicamcinchak requested a review from a team August 29, 2024 10:47
Copy link
Contributor

@DafyddLlyr DafyddLlyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@jessicamcinchak jessicamcinchak merged commit 04c7951 into main Aug 29, 2024
5 checks passed
@jessicamcinchak jessicamcinchak deleted the jess/bump-drawing-labels branch August 29, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants