Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.0.0-alpha.0 #478

Merged
merged 2 commits into from
Aug 26, 2024
Merged

v1.0.0-alpha.0 #478

merged 2 commits into from
Aug 26, 2024

Conversation

jessicamcinchak
Copy link
Member

@jessicamcinchak jessicamcinchak commented Aug 24, 2024

Queuing up a pre-release !

After this merges, will run npm publish --tag next rather than typical npm publish per thread here: https://gist.github.com/schmich/d04acc4b02b45e489f329cfdf3280a3f?permalink_comment_id=4483624#gistcomment-4483624

Copy link

netlify bot commented Aug 24, 2024

Deploy Preview for oslmap ready!

Name Link
🔨 Latest commit bb0ceb9
🔍 Latest deploy log https://app.netlify.com/sites/oslmap/deploys/66caf0a8066736000806c243
😎 Deploy Preview https://deploy-preview-478--oslmap.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jessicamcinchak jessicamcinchak changed the title v1.0.0-alpha v1.0.0-alpha.0 Aug 25, 2024
Copy link
Contributor

@DafyddLlyr DafyddLlyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know we're awaiting a few more merges, but all here looks good to me!

- Similarly, the `featuresAreaChange` event dispatched by `clickFeatures` has been deprecated and rolled into `featuresGeojsonChange` event ([#479](https://github.com/theopensystemslab/map/pull/479))
- `areaUnit` prop has been deprecated and you'll find the calculated area in _both_ `squareMetres` and `hectares` by default now in `geojsonChange` event data above ([#479](https://github.com/theopensystemslab/map/pull/479))

We think the above deprecations will mean simpler, _more_ flexible configurations and subscriptions for end-users, but if you were relying on any of the deprecated props, cannot achieve feature parity with the alternatives, or find a regression we've overlooked, please open an [Issue](https://github.com/theopensystemslab/map/issues)!
Copy link
Contributor

@DafyddLlyr DafyddLlyr Aug 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tone is great, nice to encourage issues to be opened 👌

@jessicamcinchak jessicamcinchak marked this pull request as ready for review August 26, 2024 10:55
@jessicamcinchak jessicamcinchak merged commit 677879c into main Aug 26, 2024
5 checks passed
@jessicamcinchak jessicamcinchak deleted the v1.0.0-alpha branch August 26, 2024 11:01
@jessicamcinchak
Copy link
Member Author

npm publish --tag next worked exactly as expected ✅

Screenshot from 2024-08-26 13-06-51

@DafyddLlyr
Copy link
Contributor

Nice! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants