chore: simplify props related to configuring basemap layers #476
Conversation
✅ Deploy Preview for oslmap ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| source.getUrls()?.forEach((url) => expect(url).toMatch(/api.os.uk/)); | ||
| }); | ||
|
|
||
| it.skip("loads MapboxSatellite basemap when a Mapbox access token is provided", async () => { |
There was a problem hiding this comment.
See @todo comment in layers.ts - can't quite figure out how to set a custom property on a VectorLayer specifically! Not throwing any openlayer type errors, but also not coming through in the layer markup.
Feature working as expected, just relying on name for test-ability!
There was a problem hiding this comment.
Tricky one! I'd try logging out getAllLayers() and check we're not falling back to OSM here for some reason related to our testing setup. Sure you've tried this! Happy to take a closer look if this still doesn't narrow things down.
| source.getUrls()?.forEach((url) => expect(url).toMatch(/api.os.uk/)); | ||
| }); | ||
|
|
||
| it.skip("loads MapboxSatellite basemap when a Mapbox access token is provided", async () => { |
There was a problem hiding this comment.
Tricky one! I'd try logging out getAllLayers() and check we're not falling back to OSM here for some reason related to our testing setup. Sure you've tried this! Happy to take a closer look if this still doesn't narrow things down.
|
Going to merge this one as-is for an |
Follow-up per #475 (comment) & #473 (and working towards a stable release to support
MapAndLabelin Planx!)Key changes:
basemapprop with enum values"OSVectorTile" (default) | "OSRaster" | "MapboxSatellite" | "OSM"disableVectorTilesandapplySatelliteStyleosApiKey(across map and address-autocomplete components)osVectorTilesApiKey,osFeaturesApiKey,osPlacesApiKeyosCopyrightdefault string to no longer use our license number 🙈os-layers.ts(renaming file tolayers.tssince now OSM & Mapbox too) & adds more complete test coverage