Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ability to set multiple custom attributions and collapse #424

Merged
merged 1 commit into from
Jan 2, 2024

Conversation

jessicamcinchak
Copy link
Member

Previously, the map supported a single prop osCopyright to specify the basemap attibution. This was un-collapsed by default and not configurable.

Now, we'll support multiple copyright props and expose the collapse prop to the user. Multiple copyrights are styled to be stacked on top of each other, rather than single-line.

Before / still default state:
Screenshot from 2024-01-02 12-45-01

Now / maximum three distinct attributions:
Screenshot from 2024-01-02 12-43-28

Now / collapsed attributions:
Screenshot from 2024-01-02 12-43-13

Copy link

netlify bot commented Jan 2, 2024

Deploy Preview for oslmap ready!

Name Link
🔨 Latest commit f13ca81
🔍 Latest deploy log https://app.netlify.com/sites/oslmap/deploys/6593f89691f7a500079c7284
😎 Deploy Preview https://deploy-preview-424--oslmap.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jessicamcinchak
Copy link
Member Author

Auto-red line journey

@jessicamcinchak jessicamcinchak requested a review from a team January 2, 2024 11:52
@jessicamcinchak jessicamcinchak changed the title feat: ability to set multiple custom attributions per vector source and collapse feat: ability to set multiple custom attributions and collapse Jan 2, 2024
Copy link
Contributor

@DafyddLlyr DafyddLlyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! Nice and simple.

@jessicamcinchak jessicamcinchak merged commit 5bfd44f into main Jan 2, 2024
5 checks passed
@jessicamcinchak jessicamcinchak deleted the jess/custom-attributions branch January 2, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants