feat: add gas object to Household #296
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
DafyddLlyr
requested changes
Jan 24, 2025
zz-hh-aa
force-pushed
the
oz/household-gas-object
branch
from
97a2596 to
519c282
Compare
DafyddLlyr
reviewed
Jan 24, 2025
app/models/Household.ts
Outdated
Comment on lines
41
to
46
| public gasDemand = { | ||
| kwhExistingBuildYearly: 0, | ||
| kwhNewBuildOrRetrofitYearly: 0, | ||
| billExistingBuildYearly: 0, | ||
| billNewBuildOrRetrofitYearly: 0 | ||
| } |
There was a problem hiding this comment.
Does this have to be an instantiated object, or can it just be a type?
There was a problem hiding this comment.
Heh this was me confusing myself 😓 changed back to type in eca2ba6
DafyddLlyr
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When working on social value, I found we needed to access the kwh demand figure from
Household, so this PR refactorsHouseholdto store those values in a newgasDemandobject property and makes its methods more concise too.