feat: Gracefully handle non-English postcodes #244
Merged
+77
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
DafyddLlyr
changed the base branch from
dp/price-paid-summary-table
to
dp/query-pp-summary-table
DafyddLlyr
commented
Jan 8, 2025
Comment on lines
+76
to
+88
| case "ITL3_NOT_FOUND": | ||
| case "INSUFFICIENT_PRICES_PAID_DATA": | ||
| methods.setError( | ||
| "housePostcode", | ||
| { message: | ||
| "Insufficient data for this postcode. Please try again with a different postcode" | ||
| } | ||
| ); | ||
| break; |
There was a problem hiding this comment.
We could handle these two cases differently, but right now this is a little white-lie about non-English postcodes.
DafyddLlyr
force-pushed
the
dp/gracefully-handle-missing-postcodes
branch
from
07b1e35 to
0b59b57
Compare
app/data/itlRepo.ts
Outdated
|
|
||
| throw new APIError({ | ||
| status: 500, | ||
| message: `Data error: Unable get get itl3 for postcode district ${postcodeDistrict}`, |
There was a problem hiding this comment.
minor typo 'get get'
There was a problem hiding this comment.
Great catch - fixed in ecd1570
gabrielegranello
approved these changes
Jan 9, 2025
There was a problem hiding this comment.
That's very elegant! If I get it correctly:
- A new object
APIErrorCodeis created. This extends the currentErrorclass APIErrorCodecan be of 3 types:| "ITL3_NOT_FOUND" | "INSUFFICIENT_PRICES_PAID_DATA" | "UNHANDLED_EXCEPTION";- If the Error code type 1 or 2 is returned by the API, we trigger the form validation with message "Insufficient data for this postcode. Please try again with a different postcode"
Otherwise we triggerconsole.logwith the default error message from the generalErrorclass. I assume errors such as : failing to connect to the database or similar will follow in this category, is that correct?
|
@gabrielegranello Perfectly correct! In future it would be nice to handle unhandled erorrs a bit better (e.g. logging the error to an eternal monitoring service, displaying a "try again" status to the user), but for now we just return the user the specific errors we care most about and throw unhandled errors. |
DafyddLlyr
force-pushed
the
dp/query-pp-summary-table
branch
from
b364c36 to
2a26cf3
Compare
DafyddLlyr
force-pushed
the
dp/gracefully-handle-missing-postcodes
branch
from
ecd1570 to
164da34
Compare
DafyddLlyr
added a commit
that referenced
this pull request
Jan 9, 2025
* feat: Query new `PricePaidSummary` model * test: Update test cases * feat: Gracefully handle non-English postcodes (#244) * feat: Error handling for non-English postcodes * fix: Typos * test: Fix tests for new API errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
APIErrorclassScreen.Recording.2025-01-08.at.16.17.44.mov