Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Simplify CalculatorInput layout logic #243

Merged
merged 1 commit into from
Jan 9, 2025
Merged

feat: Simplify CalculatorInput layout logic #243

merged 1 commit into from
Jan 9, 2025

Conversation

DafyddLlyr
Copy link
Contributor

@DafyddLlyr DafyddLlyr commented Jan 8, 2025 •
edited
Loading

  • Adds View type
  • Removes else and else if clauses
  • Removes type casing

@vercel Vercel
Copy link

vercel bot commented Jan 8, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fairhold-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 8, 2025 3:20pm

@DafyddLlyr DafyddLlyr marked this pull request as draft January 8, 2025 15:20
@DafyddLlyr DafyddLlyr marked this pull request as ready for review January 8, 2025 16:33
@DafyddLlyr DafyddLlyr requested a review from a team January 8, 2025 16:33
zz-hh-aa
zz-hh-aa approved these changes Jan 9, 2025
View reviewed changes
Copy link
Collaborator

@zz-hh-aa zz-hh-aa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super clear, cheers!

@DafyddLlyr DafyddLlyr merged commit 097ef31 into main Jan 9, 2025
5 checks passed
@DafyddLlyr DafyddLlyr deleted the dp/simplify-main-page branch January 9, 2025 11:20
@DafyddLlyr DafyddLlyr mentioned this pull request Jan 9, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zz-hh-aa zz-hh-aa zz-hh-aa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DafyddLlyr @zz-hh-aa