Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Rename gdhi, add not null constraints #163

Merged
merged 2 commits into from
Dec 13, 2024
Merged

feat: Rename gdhi, add not null constraints #163

merged 2 commits into from
Dec 13, 2024

Conversation

DafyddLlyr
Copy link
Contributor

@DafyddLlyr DafyddLlyr commented Dec 6, 2024

What does this PR do?

  • Renames columns to snake_case
  • Adds NOT NULL constraints
  • Updates code to account for non-nullable return types

Copy link

vercel bot commented Dec 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fairhold-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 13, 2024 2:38pm

@DafyddLlyr DafyddLlyr changed the base branch from main to dp/rename-build-prices-table December 6, 2024 16:46
@DafyddLlyr DafyddLlyr changed the title dp/ghdi table feat: Rename gdhi, add not null constraints Dec 6, 2024
@DafyddLlyr DafyddLlyr requested a review from a team December 6, 2024 16:47
},
},
select: { gdhi2020: true },
});

return gdhi2020 as number;
return gdhi2020;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just flagging that this will be 2022 after update :)

Base automatically changed from dp/rename-build-prices-table to main December 13, 2024 14:29
@DafyddLlyr DafyddLlyr merged commit 6321c94 into main Dec 13, 2024
5 checks passed
@DafyddLlyr DafyddLlyr deleted the dp/ghdi-table branch December 13, 2024 14:38
zz-hh-aa pushed a commit that referenced this pull request Dec 18, 2024
* feat: Rename gdhi tables, add not null constraints

* test: Update test case
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants