feat: maintenance calculations #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
zz-hh-aa
force-pushed
the
oz/maintenance
branch
from
411ed3f to
d69b480
Compare
zz-hh-aa
force-pushed
the
oz/maintenance-calculations
branch
from
b86060f to
720accd
Compare
DafyddLlyr
reviewed
Nov 1, 2024
app/models/ForecastParameters.ts
Outdated
| * @param maintenancePercentage - Maintenance spend value from form ("0.015" | "0.02" | "0.0375") | ||
| * @returns ForecastParameters with updated maintenance cost | ||
| */ | ||
| export function createForecastParameters(maintenancePercentage: string): ForecastParameters { |
There was a problem hiding this comment.
I think there's probably scope to simplify a fair few things in this PR by making sure that maintenancePercentage (and MAINTENANCE_LEVELS) are numbers at all times.
Even if it's a string value in the input, we can use Zod to refine it to a number for submission, and then keep it as a number going forward in out codebase.
There was a problem hiding this comment.
Ah great catch, I think I've just pushed a fix for this now.
zz-hh-aa
force-pushed
the
oz/maintenance-calculations
branch
from
9694e58 to
532dc3a
Compare
DafyddLlyr
approved these changes
Nov 7, 2024
zz-hh-aa
force-pushed
the
oz/maintenance
branch
from
2c38fcf to
18fc750
Compare
to overwrite DEFAULT_FORECAST_PARAMETERS with user input
zz-hh-aa
force-pushed
the
oz/maintenance-calculations
branch
from
532dc3a to
19b6eb8
Compare
for ForecastParameters file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses #130 as base (that handles the UI, this handles the calculations).
What does this PR do?
maintenanceSpendtomaintenancePercentagefor claritymaintenancePercentageto relevant schemas and testscreateForecastParameters()to overwriteDEFAULT_FORECAST_PARAMETERSwith user input maintenance spend percentageCloses #133.