chore: fix typo in mortgage 'principle' #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
DafyddLlyr
reviewed
Oct 17, 2024
There was a problem hiding this comment.
Very good spot thanks - there's a mismatch between a number of functions and the class property.
I'm not sure this is a spelling issue, or UK vs US spellings issue, though - principle and principal are two different words and I think "principal" is right here.
Principal in a mortgage sense is the amount borrowed, but I think is often confused with the banking term "mortgage in principle" (i.e. in theory you can borrow based on what we know, as in "from first principles").
|
Excellent spot! I think you're right and I got wires crossed with mortgage in principle, in any case all consistent to 'principal' now. |
DafyddLlyr
requested changes
Oct 17, 2024
Co-authored-by: Dafydd Llŷr Pearson <[email protected]>
DafyddLlyr
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does what it says--fixes instances of mortgage
principaltoprinciple.