feature: Convenient methods for getting component type instances #712
+103
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spomky
force-pushed
the
features/convenient-methods
branch
from
4198f39
to
188934f
Compare
Spomky
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
As explained in #711.
Please note that I am no typescript developer, so please do not hesitate to show me the right way for implementing this.
Also, I am not sure of the naming for these functions. In particular, I propose e.g.
getTooltipList()whilegetTooltips()whould be more appropriate to me. This is due to weird cases that areDismissandTabswheregetTabss()makes no sense.Could be completely removed if you disagree with these methods.
Kind regards.