Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore src/packaging/data for apache rat checks #808

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jsanda
Copy link
Contributor

@jsanda jsanda commented Dec 9, 2019

docker-compose stores data files in src/packaging/data, and it was causing the rat checks to fail for me when building locally.

docker-compose stores data files in src/packaging/data, and it was causing the
rat checks to fail for me when building locally.
@michaelsembwever
Copy link
Member

I think this would be better solved by sticking to placing generated files under an existing build directories, instead of in the source tree. (and each src module having only the one "build" directory.)

Can we move the data directory to be under src/packaging/build/ ?
(we'd also be able to remove the data line from .gitignore)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants