MED-100 Make read_timeout default to None, only use it if set #813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rzvoncek
force-pushed
the
radovan/fix-default-timeouts
branch
7 times, most recently
from
681413b
to
d02e684
Compare
rzvoncek
changed the title
adejanovski
reviewed
Oct 28, 2024
| @@ -158,7 +158,7 @@ async def _download_blob(self, src: str, dest: str): | |||
| stream = await self.gcs_storage.download_stream( | |||
| bucket=self.bucket_name, | |||
| object_name=object_key, | |||
| timeout=self.read_timeout if self.read_timeout is not None else -1, | |||
| timeout=self.read_timeout, | |||
There was a problem hiding this comment.
Question: Disabling the timeout seemed to be done by setting the value to -1 previously and now it's set to None. Does that work as well?
There was a problem hiding this comment.
I actually do not know.
Since it's really tedious to find this out empirically, let's just default to -1 for GCS. The commit 3dd0a55 does that.
rzvoncek
force-pushed
the
radovan/fix-default-timeouts
branch
10 times, most recently
from
34f295c
to
1008c55
Compare
rzvoncek
force-pushed
the
radovan/fix-default-timeouts
branch
7 times, most recently
from
798c38c
to
d6a037f
Compare
rzvoncek
force-pushed
the
radovan/fix-default-timeouts
branch
9 times, most recently
from
cbaec83
to
73442f2
Compare
rzvoncek
force-pushed
the
radovan/fix-default-timeouts
branch
from
73442f2
to
d611396
Compare
|
adejanovski
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #814