Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

purge decommissioned nodes backups #603

Merged
merged 12 commits into from
Sep 4, 2023
Merged

purge decommissioned nodes backups #603

merged 12 commits into from
Sep 4, 2023

Conversation

RachanKaur
Copy link
Contributor

Fixes: #447

@RachanKaur RachanKaur self-assigned this Jul 26, 2023
@RachanKaur RachanKaur marked this pull request as draft July 26, 2023 14:01
@codecov
Copy link

codecov bot commented Jul 26, 2023 •
edited
Loading

Codecov Report

Merging #603 (66f6720) into master (d68fea3) will increase coverage by 0.03%.
Report is 2 commits behind head on master.
The diff coverage is 78.72%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #603      +/-   ##
==========================================
+ Coverage   80.97%   81.00%   +0.03%     
==========================================
  Files          58       59       +1     
  Lines        4599     4654      +55     
  Branches      686      743      +57     
==========================================
+ Hits         3724     3770      +46     
- Misses        848      857       +9     
  Partials       27       27
Files Changed Coverage Δ
medusa/medusacli.py 0.00% <0.00%> (ø)
medusa/purge_decommissioned.py 85.36% <85.36%> (ø)
medusa/storage/__init__.py 93.52% <100.00%> (+0.05%) ⬆️

... and 2 files with indirect coverage changes

@RachanKaur RachanKaur marked this pull request as ready for review July 27, 2023 09:11
@RachanKaur RachanKaur requested a review from rzvoncek July 27, 2023 09:11
@RachanKaur RachanKaur marked this pull request as draft July 27, 2023 10:34
adejanovski
adejanovski requested changes Aug 7, 2023
View reviewed changes
.gitignore Outdated Show resolved Hide resolved
medusa/purge_decommissioned.py Outdated Show resolved Hide resolved
tests/purge_decommissioned_test.py Outdated Show resolved Hide resolved
medusa/purge_decommissioned.py Outdated Show resolved Hide resolved
@RachanKaur RachanKaur force-pushed the 447-purge_decommissioned branch 3 times, most recently from 24f979a to dc2f4a2 Compare August 15, 2023 15:02
@RachanKaur RachanKaur marked this pull request as ready for review August 15, 2023 15:42
adejanovski
adejanovski requested changes Aug 18, 2023
View reviewed changes
medusa/medusacli.py Outdated Show resolved Hide resolved
tests/integration/features/steps/integration_steps.py Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Aug 18, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@RachanKaur RachanKaur added the ready-for-review Issues in the state 'ready-for-review' label Aug 22, 2023
@adejanovski adejanovski merged commit 8b592dd into master Sep 4, 2023
28 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adejanovski adejanovski adejanovski approved these changes

@rzvoncek rzvoncek Awaiting requested review from rzvoncek

Assignees

@RachanKaur RachanKaur

Labels
ready-for-review Issues in the state 'ready-for-review'
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Purge should account for nodes that have been decommissioned
2 participants
@RachanKaur @adejanovski